Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Exampleの動作チェックを追加 #701

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Add: Exampleの動作チェックを追加 #701

merged 1 commit into from
Dec 3, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

Python Exampleの動作チェックを追加します。

関連 Issue

その他

（なし）

qryxip
qryxip approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Hiroshiba
Hiroshiba approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

kotlin exampleのテストもあると良さそう感ありますね。issue作ってみました。

（この辺り各言語ごとにissue作るの大変なので、なんかいい方法があると嬉しそう）

@Hiroshiba Hiroshiba merged commit cf4c6d3 into VOICEVOX:main Dec 3, 2023
31 checks passed
qryxip added a commit to qryxip/voicevox_core that referenced this pull request Dec 8, 2023
@qryxip
VOICEVOX#701 の動作チェックにrun-asyncio.pyを追加
d7fed1f
Hiroshiba pushed a commit that referenced this pull request Dec 9, 2023
@qryxip
PythonのブロッキングAPIを実装 (#706)
00a1c53 
* `blocking.{OpenJtalk,UserDict}`

* `voicevox_core.asyncio`

* Blackとisortに`--diff`を付ける

* isort

* `blocking.{Synthesizer,VoiceModel}`

* `add_class`

* example/python/run.pyをブロッキング版に

* テストをコピペで実装

* #701 の動作チェックにrun-asyncio.pyを追加

* `shell: bash`

* #699 のusage.mdを更新

* スタイルの統一

* run-asyncio.pyのコメント変更
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@qryxip qryxip qryxip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python exampleが正しく動くかテストしたい
3 participants
@sevenc-nanashi @Hiroshiba @qryxip